replace $request->session() with session()

[inmanturbo]

This PR (refactor) replaces The calls to methods on $request->session() with session() as per @calebporzio 's recommendation in livewire/livewire#936 (comment).

This also eliminates the need for the if ($request->hasSession()) condition in my previous PR, thus bringing the code back one level of indentation.

Tested with the following steps:

laravel new jetstream-demo

cd jetstream-demo

composer require laravel/jetstream

php artisan jetstream:install livewire

npm install && npm run dev

vi phpunit.xml

-        <!-- <server name="DB_CONNECTION" value="sqlite"/> -->
-       <!-- <server name="DB_DATABASE" value=":memory:"/> -->
+       <server name="DB_CONNECTION" value="sqlite"/>
+       <server name="DB_DATABASE" value=":memory:"/>

php artisan test

Also tested in chromium browser against #730

---

@telkins @Loots-it

#742

#750 (comment)

[taylorotwell]

Is this actually fixing a problem? It sounds like it's just a preference thing?

[inmanturbo]

It sounds like it's just a preference thing?

Yeah I suppose it is more of a preference thing, since we're really not sure if there will be a problem. Livewire was having issues with Request but in this case it may never be a problem for Jetstream, which is working fine as it is.

[peterfox]

Replacing $request->session() with the Session contract fixes the DeleteUserForm test for me. Otherwise it fails due to the request not having a stateful session, most likely because the way Livewire component testing works.