Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Hide AppLayout header if no slot defined in Page component #650

Merged
merged 1 commit into from
Jan 25, 2021
Merged

[2.x] Hide AppLayout header if no slot defined in Page component #650

merged 1 commit into from
Jan 25, 2021

Conversation

nicolasbeauvais
Copy link
Contributor

On Jetstream Inertia when creating a Page component with no #header slot, the AppLayout display an empty unnecessary header instead of no header.

Before:
Opera Snapshot_2021-01-24_133749_next-ci localhost

After:
Opera Snapshot_2021-01-24_133921_next-ci localhost

@driesvints driesvints changed the title Hide AppLayout header if no slot defined in Page component [2.x] Hide AppLayout header if no slot defined in Page component Jan 24, 2021
@taylorotwell
Copy link
Member

Same change needs to be made to Livewire stack.

@taylorotwell taylorotwell merged commit 49a2949 into laravel:2.x Jan 25, 2021
@taylorotwell
Copy link
Member

I added it to the Livewire stack.

@nicolasbeauvais
Copy link
Contributor Author

Thanks for merging and replicating the change to the Livewire stack 👍

@nicolasbeauvais nicolasbeauvais deleted the patch-1 branch January 25, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants