Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set fully qualified url for dashboard,api tokens,profile show,team se… #63

Closed
wants to merge 1 commit into from
Closed

set fully qualified url for dashboard,api tokens,profile show,team se… #63

wants to merge 1 commit into from

Conversation

joisarjignesh
Copy link
Contributor

set fully qualified URL for dashboard,api tokens,profile show,team settings and create new team

@nathanheffley
Copy link
Contributor

Does this solve an issue you were having? I'm interested in what benefit you think absolute URLs provide here.

@kdunn2856
Copy link

Nathan,

Thank you so very much for your gracious help!

I hope to some day return the favor.

Kim Dunn

@kdunn2856
Copy link

Thank you very much for the information and direction. It is very helpful.

Kim Dunn

@pedroufv
Copy link
Contributor

pedroufv commented Sep 6, 2020

Why use url('/dashboard') instead of route('dashboard')?

I saw on the welcome.blade using url('/dashboard') too, but i don't know if has benefits

@joisarjignesh
Copy link
Contributor Author

Why use url('/dashboard') instead of route('dashboard')?

I saw on the welcome.blade using url('/dashboard') too, but i don't know if has benefits

i did't know route('dashboard') exists or not so i used url instead of route.

@joisarjignesh
Copy link
Contributor Author

Does this solve an issue you were having? I'm interested in what benefit you think absolute URLs provide here.
@nathanheffley @taylorotwell

When using absolute URLs, the link always points to the correct URL and when you have multiple projects structure like

html
      /laravel7
      /laavel8
      /jestream
     /project/xyz
     /project/foo

and you are using like apache(or nginx,xampp) and your single(only one) host file pointing(documentRoot /var/www/html) the main apache folder html.. then you are using relative url it will fall down (because it will always point to main root folder)

In general, it is considered best-practice to use relative URLs, so that your website will not be bound to the base URL of where it is currently deployed. For example, it will be able to work on localhost, as well as on your public domain, without modifications.
see question on stackoverflow https://stackoverflow.com/questions/2005079/absolute-vs-relative-urls

so sent you pull request for absolute url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants