[2.x] Improve registration test #595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I was going to submit another PR later today based on your suggestion #549 (comment) |
|
I guess I don't understand really. If you enable that feature, just modify your own tests? |
|
@taylorotwell Yeh, I understand your point - tbf I did this more for developer convenience and the added bonus of avoiding more of the same issue / PR's coming in for this topic |
This was referenced Jan 7, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR's (#549 #593) have been attempted to fix this test as it currently fails for developers when their application's
jetstream.featuresconfig contains thetermsfeature.This PR improves and updates the current test by ensuring the terms feature is not in the
jetstream.featuresconfig.An additional test has been added to test registration with terms enabled.