Provide a way of customizing/disabling the default routes #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1guelpf
changed the title
jbrooksuk
approved these changes
Sep 5, 2020
|
@jbrooksuk I'm confused, was this merged or rejected? |
|
Weird! I approved the PR, using the GitHub mobile app. |
|
I also can't open it again from my phone. How strange! |
|
@taylorotwell @driesvints any idea what’s happened here? |
Closed
|
I think pull bot performed a force-push which invalidated the commit in m1guelpf's branch... this PR now has zero commits to merge. |
|
Opened #67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a way of disabling registration of the default routes like other Laravel packages already allow (Cashier, for example). It also adds an option to publish the routes for the adapter you're currently using to your routes folder.
See #44