[2.x] Accessibility Keyboard Navigation Improvements for Add Team Member Role Options #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylormaguire
changed the title
taylormaguire
changed the title
|
Thank you. I have been wanting to do this but didn't really have the know-how to make it happen. ❤️ |
|
Thanks!, I just realized need to do the same for the Modal, i can submit a PR later tonight.
On Oct 31, 2020, at 1:01 PM, Taylor Otwell <[email protected]<mailto:[email protected]>> wrote:
Merged #421<#421> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#421 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AELEMKND7RZHF62VSXSLB7LSNRUJJANCNFSM4TFYPFPQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes that the Add Team Member section Role options are changed to Buttons instead of Div's. Making this change will increase Accessibility and will allow the end-users to select a Role using the keyboard and not just the mouse.
Tailwind focus border styles have been applied to improve accessibility and the loop has been modified to allow for rounded corners as appropriate in the button grouping.
I've made changes to both the Livewire and Inertia stubs.