Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Fix Livewire Modal Closing Issue By Bumping Alpine To 2.7.3 #404

Merged
merged 1 commit into from
Oct 27, 2020
Merged

[1.x] Fix Livewire Modal Closing Issue By Bumping Alpine To 2.7.3 #404

merged 1 commit into from
Oct 27, 2020

Conversation

calebporzio
Copy link
Contributor

@calebporzio calebporzio commented Oct 27, 2020

Closes #384

The issue where modals transition in, but not out when Livewire is the one to trigger the state change has been fixed in the latest versions of Livewire and Alpine:

Livewire: v2.3.1
Alpine: v2.7.3

The original issue should be partially fixed in older versions of Alpine (for existing installs), but a few more edge cases have been addressed that will only be fixed for people running Alpine 2.7.3 and above.

Namely, without 2.7.3 there are few transition interruption edge cases.

For example: if a user closes a modal in Jetstream, and while it's transitioning out, they somehow re-open it, it will disappear.

I'm not even sure if this case is possible to re-create in Jetstream, but just noting it here.

@calebporzio calebporzio changed the title Fix Livewire Modal Closing Issue By Bumping Alpine To 2.7.3 [1.x] Fix Livewire Modal Closing Issue By Bumping Alpine To 2.7.3 Oct 27, 2020
@taylorotwell taylorotwell merged commit e37dbff into laravel:1.x Oct 27, 2020
@taylorotwell
Copy link
Member

You're so big brained. 🧠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jetstream modals are closing abruptly on dismiss
2 participants