Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show scroll bars #40

Closed
wants to merge 1 commit into from
Closed

Always show scroll bars #40

wants to merge 1 commit into from

Conversation

bonzai
Copy link
Contributor

@bonzai bonzai commented Sep 3, 2020

Currently, the vertical scroll bar is only shown when needed, so sometimes the page is "jumping":

scroll

After this PR, the scroll bars will always be visible.

@zaknesler
Copy link
Contributor

overflow: scroll never looks good on Windows

image

@bonzai
Copy link
Contributor Author

bonzai commented Sep 4, 2020

@zaknesler Nothing wrong with your screenshot.

@zaknesler
Copy link
Contributor

@bonzai An empty scrollbar isn't a common choice of any website, it should only appear when necessary. The "jumping" is expected when switching to a page with longer content.

image

@octoper
Copy link
Contributor

octoper commented Sep 4, 2020

@bonzai The page is has more content that's why the Profile settings page has scrollbars, the Dashboard page on the other hand it doesn't so is has no scrollbars.
You don't need to show scrollbars on every page its not attractive to have disable scrollbars or even have scrollbars on a page that never scrolls, the users might be confused sometimes

@bonzai
Copy link
Contributor Author

bonzai commented Sep 4, 2020

@zaknesler Well, I would expect that the menu or other elements of the page are always in the same place, no matter if the scroll bar is visible or not.

@taylorotwell
Copy link
Member

This is a stub so you can change it in your own app.

@bonzai bonzai deleted the always-show-scroll-bars branch September 4, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants