Upgrade Jetstream to the latest InertiaJS #344
Conversation
| onSuccess: () => { | ||
| if (! this.createApiTokenForm.hasErrors()) { | ||
| this.displayingToken = true | ||
| } |
There was a problem hiding this comment.
This is still called onSuccess even if there are validation errors? I guess because it's a redirect on the server side?
There was a problem hiding this comment.
Yeah, it still gets called. onSuccess in Inertia doesn't have much to do with the HTTP request itself succeeding, but instead means that a valid (usable) Inertia response came back. https://inertiajs.com/manual-visits#promise-deprecation
Server-side redirects don't really affect this.
There was a problem hiding this comment.
Yes, exactly. Success = successful Inertia visit. It's like a then() before.
|
@claudiodekker I have released the jetstream-js PR as 1.0.0. We can update the master branch of this repository to install ^1.0.0 of |
|
I have made that change. |
|
Dude, you're ⚡ 🤣 |
Co-authored-by: Jonathan Reinink <[email protected]>
|
Just noticed. Doesn't this entire PR need to go to |
|
@claudiodekker In light of changing the branch to |
|
@taylorotwell Yeah, sure, no worries.. I'll get right on it 👍 |
|
@taylorotwell Done. |
|
Thanks! |
This PR updates Jetstream to use the latest version of Inertia (
0.4) & Inertia Vue (0.3).Please note: Changes in this PR rely upon the changes introduced in laravel/jetstream-js#8, meaning this PR is breaking right now.