Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Add dependancy-less modal focus trapping #294

Merged
merged 2 commits into from
Oct 1, 2020
Merged

[1.x] Add dependancy-less modal focus trapping #294

merged 2 commits into from
Oct 1, 2020

Conversation

calebporzio
Copy link
Contributor

This PR adds "focus-trapping" to the modals in Jetstream.

This means that pressing "Tab" and "Shift+Tab" will only cycle through focusing elements inside the modal.

Here's a gif:
focus_trap

@calebporzio calebporzio changed the title Add dependancy-less modal focus trapping [1.x] Add dependancy-less modal focus trapping Oct 1, 2020
@calebporzio
Copy link
Contributor Author

Ah, just saw you closed the last one @taylorotwell. Feel free to close this if you don't want it, just figured I'd weigh in.

I imagine you'll get other requests for this from people concerned with accessibility.

It's actually one of the things most modals don't get right in applications and including it inside Jetstream would be adding a lot of value to applications.

@taylorotwell taylorotwell merged commit b046642 into laravel:1.x Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants