[1.x] Use Inertia's [only] lazy evaluation
#250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems sensible. |
|
@taylorotwell I'll try to find a couple other spots that can use this optimization before completing this. |
chrysanthos
reviewed
Sep 22, 2020
| @@ -82,8 +82,9 @@ | |||
|
|
|||
| methods: { | |||
| updateTeamName() { | |||
| this.form.put('/teams/' + this.team.id, { | |||
| preserveScroll: true | |||
| this.form.put(`/teams/'${this.team.id}`, { | |||
There was a problem hiding this comment.
There is an extra quote here.
Suggested change
| this.form.put(`/teams/'${this.team.id}`, { | |
| this.form.put(`/teams/${this.team.id}`, { |
driesvints
changed the title
[only] lazy evaluation[only] lazy evaluation
driesvints
changed the title
[only] lazy evaluation[only] lazy evaluation
|
Re-open when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
putrequest for updating theteamname to take advantage of the lazy evaluation that Inertia offers outlined here https://inertiajs.com/responses#lazy-evaluationThis change will allow Inertia reduce the number of quieres needed to render the view.