Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Ensure models directory exists #210

Closed
wants to merge 1 commit into from
Closed

[1.x] Ensure models directory exists #210

wants to merge 1 commit into from

Conversation

rojtjo
Copy link

@rojtjo rojtjo commented Sep 16, 2020

I noticed while attempting to install Jetstream in an existing project that it crashed halfway through because I didn't have a models directory.
This change ensures the directory exists.

@taylorotwell
Copy link
Member

All new 8.x projects already have a models directory.

@rojtjo
Copy link
Author

rojtjo commented Sep 16, 2020

True, the problem only arises when upgrading from an older version, or when you decide to install Jetstream later after already having moved the User model to a different directory (and obviously removing the Models/ directory).

@driesvints
Copy link
Member

@rojtjo Jetstream is meant for new Laravel installs. If you're migrating your existing app to Jetstream you'll need to do some manual work.

@rojtjo
Copy link
Author

rojtjo commented Sep 16, 2020

Yeah, I figured already! Just assumed (when installing the first time) that it was checking if a models directory exists like it does for the make:model command. 😅

Anyways, thanks for the explanation!

@rojtjo rojtjo deleted the models-dir-patch branch September 16, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants