fix: position of confirm 2fa button to right #1469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's OK as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the position of the confirmation button for enabling two-factor authentication. It was previously displayed to the left of the cancel button, which differs from the Jetstream standard (cancel on the left, confirm on the right). To achieve this, I only needed to change the position of the cancel button code and modify an if statement. I am not yet familiar with integration testing, otherwise I would have proceeded with this action.
I believe that this modification improves the user experience, which is why I have implemented it in a personal project of mine.
This is my application, please ignore the changes in theme (im using daysi ui).