Support confirmPassword false for 2FA #1464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crynobone
changed the title
|
I don't think we ever really meant this to be disabled. It was only added for backwards compatibility at the time. I suggest just removing stuff from your stubs if you want to disable it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fortify, as well as the Jetstreams 2FA component class has code that supports skipping the password confirmation, if set in the according configuration via a feature-flag.
The current implementation of the livewire view however, does not respect that config.
This admittedly naive approach fixes this.
The feature is especially useful for applications that don't make use of passwords (for example because they are using business SSO but still want to enforce 2FA)
This adresses issue #1463