Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] Change Inertia Modal.vue component to use a native <dialog> #1431

Merged
merged 6 commits into from
Feb 23, 2024
Merged

[4.x] Change Inertia Modal.vue component to use a native <dialog> #1431

merged 6 commits into from
Feb 23, 2024

Commits on Jan 15, 2024

  1. Change Modal to use native <dialog> instead of Vue Teleport and div

    @Smef
    Smef committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    272fd1d View commit details
    Browse the repository at this point in the history

  2. changed overflow to happen earlier, to more closely match existing be… 

    …havior and seem more responsive
    @Smef
    Smef committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    4a1692e View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. updated livewire modal to use <dialog>

    @Smef
    Smef committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    48a9bd6 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. added preventDefault to allow the regular close animation to fire nicely

    @Smef
    Smef committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    126d4c3 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. reverted <dialog> implementation

    @Smef
    Smef committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    594d4c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. added second ref for showing the slot to stop content from appearing … 

    …and disappearing, preventing modal size shifting
    @Smef
    Smef committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    321473d View commit details
    Browse the repository at this point in the history