Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typehint mutator profile_photo_url attribute function return #1396

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Typehint mutator profile_photo_url attribute function return #1396

merged 1 commit into from
Nov 3, 2023

Conversation

potsky
Copy link
Contributor

@potsky potsky commented Nov 3, 2023

We need to typehint mutator function return to let IDE Helper package know the type of the attribute.

barryvdh/laravel-ide-helper#1315 (comment)

Then PHPStan will not throw error on undefined profile_photo_url property.

We need to typehint mutator function return to let IDE Helper package know the type of the attribute.

barryvdh/laravel-ide-helper#1315 (comment)

Then PHPStan will not throw error on undefined profile_photo_url property.
@taylorotwell taylorotwell merged commit 379ff34 into laravel:4.x Nov 3, 2023
8 checks passed
@potsky potsky deleted the patch-1 branch November 3, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants