Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Dark Mode #1234

Merged
merged 1 commit into from
Jan 30, 2023
Merged

[3.x] Dark Mode #1234

merged 1 commit into from
Jan 30, 2023

Conversation

fotrino
Copy link
Contributor

@fotrino fotrino commented Jan 28, 2023

This PR introduces Dark Mode for Jetstream 3.0 based on discussions from #1229.

Notes

  • Does not conflicts with auth.user changes from #1073.
  • Includes the changes introduced to strip dark classes #1224, dark nav menu in #1225.

@fotrino fotrino mentioned this pull request Jan 28, 2023
@taylorotwell taylorotwell merged commit 202b274 into laravel:master Jan 30, 2023
@taylorotwell
Copy link
Member

Thanks!

@fotrino fotrino deleted the dark-mode-v3 branch January 31, 2023 10:30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why disabled:opacity-25 was removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the classes were copied from Breeze.
I checked the preview with dark mode & it seems a bit off, might be worth a pr to introduce it back, maybe with the new darker shades (950) introduced in tailwind 3.3 😃
Might give it a go over the weekend & submit a draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants