Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Not require Ziggy on ShareInertiaData middleware. #1024

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

xiCO2k
Copy link
Contributor

@xiCO2k xiCO2k commented Mar 30, 2022

This PR fixes #1023

Removes the addition of Ziggy on the ShareInertiaData middleware, and only add Ziggy to the HandleInertiaData stub if --ssr is passed, so that way if anyone wants to remove, they have the full control.

Thanks,
Francisco

@xiCO2k xiCO2k changed the title [2.x] Not requiring Ziggy on ShareInertiaData middleware. [2.x] Not require Ziggy on ShareInertiaData middleware. Mar 30, 2022
@taylorotwell
Copy link
Member

@xiCO2k how will this middleware actually be invoked? where is it registered with the routes?

@xiCO2k
Copy link
Contributor Author

xiCO2k commented Mar 30, 2022

Yes, the middleware is already added here:

$this->installMiddlewareAfter('SubstituteBindings::class', '\App\Http\Middleware\HandleInertiaRequests::class');

@taylorotwell taylorotwell merged commit 2c3c9c5 into laravel:2.x Mar 30, 2022
@xiCO2k xiCO2k deleted the fix/requirement-ziggy branch March 30, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ziggy is no longer optional
2 participants