Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Make MultipleInstanceManager driver field customizable #51905

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

princejohnsantillan
Copy link
Contributor

It's not always the case that the field is driver. Mail for example uses transport.

I want to create my own SMS Manager and my config looks like this:

return [
  'default' => env('SMS_CHANNEL', 'vonage'),
  
  'channels' => [
    
    'vonage' => [
      'provider' => 'vonage',
      'key' => env('SMS_VONAGE_KEY'),
      'secret' => env('SMS_VONAGE_SECRET'),
    ],
    
    'twilio' => [
      'provider' => 'twilio',
      'account_sid' => env('SMS_TWILIO_ACCOUNT_SID'),
      'auth_token' => env('SMS_TWILIO_AUTH_TOKEN'),
    ],
    
    'log' => [
      'provider' => 'log',
    ]
  ]
]

I use provider here but the abstract class currently forces us to use driver only.

@taylorotwell taylorotwell merged commit 96398e9 into laravel:11.x Jun 27, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants