Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Alternate implementation to allow "safe" objects to be used by Eloquent models (without breaking mass assignment protection) #50218

Draft
wants to merge 9 commits into
base: 11.x
Choose a base branch
from
+132 −41
Draft

[11.x] Alternate implementation to allow "safe" objects to be used by Eloquent models (without breaking mass assignment protection) #50218

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c5812fb
Allow passing ValidatedInput
x7ryan Feb 23, 2024
dbe2b60
Add back type hints with new union type
x7ryan Feb 23, 2024
0e994b0
Updated forceCreate for Morphs
x7ryan Feb 23, 2024
d80febd
Typehint for forceCreate in Morphs
x7ryan Feb 23, 2024
b748958
Updated forceCreate for MorphMany
x7ryan Feb 23, 2024
7ebbd13
Typehint for forceCreate in MorphMany
x7ryan Feb 23, 2024
6bc7fd4
Fix failed tests
x7ryan Feb 23, 2024
6125131
Fix failed tests
x7ryan Feb 23, 2024
0d4accb
Fix styles
x7ryan Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix failed tests
  • Loading branch information
@x7ryan
x7ryan committed Feb 23, 2024
commit 612513124ccd0db8b28f822caecd2157b1a6bb08
4 changes: 2 additions & 2 deletions tests/Integration/Database/EloquentUpdateTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@ public function testUpdateAllowsSafeObject()
'name' => Str::random(),
]);

$model->update(new ValidatedInput(['job' => 'Developer']));
$model->update(new ValidatedInput(['title' => 'Developer']));

$model->refresh();

$this->assertSame('Developer', $model->job);
$this->assertSame('Developer', $model->title);
}

public function testUpdateWithLimitsAndOrders()
Expand Down
Loading