[11.x] Switch Js::encode() to return HtmlString #49641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
|
Thanks. Paging in @calebporzio to see if this affects Livewire. |
|
@calebporzio took a Quick Look at this one but didn't see anything wrong with it at first sight. So marking this as ready for review again. |
driesvints
approved these changes
Mar 12, 2024
|
Didn't quite get to this before L11 release. |
|
@taylorotwell does that mean this'll need to wait for Laravel 12? Can we apply this to |
|
Best to just attempt a PR @valorin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the
Js::encode()helper to return an instance ofHtmlStringrather than a raw string.The primary reason is to support using the normal escaping Blade tags:
{{ Js::encode() }}, rather than{!! Js::encode() !}}, when using this in Blade. This will then match the behaviour already possible withJs::from()which returns an instance ofHtmlableand supports{{ Js::from() }}.Since this is a breaking change, it will need to go into v11 - hence the
masterbranch.There are no downsides to this change, it may just require minor code updates - which should be trivial to identify and perform with a search for
Js::encode(.