[13.x] Refactor payment exceptions #1095
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the payment exceptions within Cashier. Atm we were still rolling separate exceptions for the different statuses of a payment. But these types of statuses can easily be derived from the encapsulated payment intent object. In general, it's unlikely that someone implementing Cashier will make abundant use of these different types of payment exceptions. We also only document the use of the parent
IncompletePayment
exception in our docs: https://laravel.com/docs/8.x/billing#handling-failed-paymentsThe sub types are currently documented but probably that's not needed as you'd usually just make use of the parent exception. If you really need to differentiate between them, then the Payment object has helper methods to do just that.
This PR also makes
->validate()
on the Payment object throw the exception for payments with the status ofrequires_confirmation
.