Focus current theme/language in palette #1198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would close #642
The implementation here is a little bit weird, but this is less trivial than it seems
PaletteViewData::run
, it gets overridden on the next widget update cycleIf someone has any pointers on how this could be cleaned up or made more idiomatic to the codebase (first contributions are always tricky!) I'd love to hear it. Thanks!
(especially this change to lapce-ui/palette.rs where Druid doesn't implement these shared methods with a trait, so I had to make the function generic over a closure that forwards to the actual method. it's pretty nasty)