Refactor to update to respond to initialization requests #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR assumes this other PR gets merged lapce/lapce-plugin-rust#18 Also rename initialize => calculate_lsp_params and do effectful calls (like start_lsp and responding to request) in handle_request. Signed-off-by: Hanif Bin Ariffin <[email protected]>
hbina
force-pushed
the
hbina-refactor-to-latest-lib
branch
from
498360d
to
af22604
Compare
ricochet1k
reviewed
Jun 13, 2023
| @@ -47,7 +47,10 @@ macro_rules! string { | |||
| String::from($s) | |||
| }; | |||
| } | |||
| fn initialize(params: InitializeParams) -> Result<()> { | |||
|
|
|||
| type LspParams = (Url, Vec<String>, Vec<DocumentFilter>, Option<Value>); | |||
There was a problem hiding this comment.
This would be better as a struct so that each of the values can have names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR assumes this other PR gets merged lapce/lapce-plugin-rust#18
Also rename
initialize=>calculate_lsp_paramsand do effectful calls (like start_lsp and responding to request) in handle_request.Signed-off-by: Hanif Bin Ariffin [email protected]