Skip to content

Commit

Permalink
CI: Bump prettier to latest version (2.4.1)
Browse files Browse the repository at this point in the history
We didn't initially upgrade because it started to (incorrectly) see
files as strict mode and chokes on things that then would be syntax
errors - but we're starting to fall behind a bit, so I'd rather put
these files on the ignore list instead.
  • Loading branch information
linusg committed Nov 21, 2021
1 parent 66c06e8 commit f538df7
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cmake.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
sudo apt-get update
sudo apt-get install libmpfr-dev libmpc-dev ninja-build e2fsprogs qemu-utils qemu-system-i386 ccache unzip
- name: Install JS dependencies
run: sudo npm install -g prettier@2.2.1
run: sudo npm install -g prettier@2.4.1
- name: Install Python dependencies
# The setup-python action set default python to python3.x. Note that we are not using system python here.
run: |
Expand Down
5 changes: 5 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
Base/home/anon/Source/js
Userland/Libraries/LibJS/Tests/builtins/Object/Object.prototype.toString.js
Userland/Libraries/LibJS/Tests/eval-aliasing.js
Userland/Libraries/LibJS/Tests/if-statement-function-declaration.js
Userland/Libraries/LibJS/Tests/invalid-lhs-in-assignment.js
Userland/Libraries/LibJS/Tests/operators/delete-global-variable.js
Userland/Libraries/LibJS/Tests/operators/delete-local-variable.js
Userland/Libraries/LibJS/Tests/unicode-identifier-escape.js
6 changes: 2 additions & 4 deletions Base/res/js/Spreadsheet/runtime.js
Original file line number Diff line number Diff line change
Expand Up @@ -479,8 +479,7 @@ sumIf.__documentation = JSON.stringify({
name: "sumIf",
argc: 2,
argnames: ["condition", "cell names"],
doc:
"Calculates the sum of cells the value of which evaluates to true when passed to `condition`",
doc: "Calculates the sum of cells the value of which evaluates to true when passed to `condition`",
examples: {
'sumIf(x => x instanceof Number, range("A1", "C4"))':
"Calculates the sum of all numbers within A1:C4",
Expand Down Expand Up @@ -524,8 +523,7 @@ averageIf.__documentation = JSON.stringify({
name: "averageIf",
argc: 2,
argnames: ["condition", "cell names"],
doc:
"Calculates the average of cells the value of which evaluates to true when passed to `condition`",
doc: "Calculates the average of cells the value of which evaluates to true when passed to `condition`",
examples: {
'averageIf(x => x > 4, range("A1", "C4"))':
"Calculate the sum of all numbers larger then 4 within A1:C4",
Expand Down

0 comments on commit f538df7

Please sign in to comment.