AK: Make FlyString-to-FlyString comparison inline & trivial

This should never boil down to more than a machine word comparison.
lanmonster · Mar 14, 2024 · d125a76 · d125a76
1 parent bc23c5b
commit d125a76
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/AK/FlyString.cpp b/AK/FlyString.cpp
@@ -89,11 +89,6 @@ StringView FlyString::bytes_as_string_view() const
  return m_data.bytes();
 }
 
-bool FlyString::operator==(FlyString const& other) const
-{
- return m_data == other.m_data;
-}
-
 bool FlyString::operator==(String const& other) const
 {
  return m_data == other;

diff --git a/AK/FlyString.h b/AK/FlyString.h
@@ -41,7 +41,7 @@ class FlyString {
  [[nodiscard]] ReadonlyBytes bytes() const;
  [[nodiscard]] StringView bytes_as_string_view() const;
 
- [[nodiscard]] bool operator==(FlyString const& other) const;
+ [[nodiscard]] ALWAYS_INLINE bool operator==(FlyString const& other) const { return m_data.raw({}) == other.m_data.raw({}); }
  [[nodiscard]] bool operator==(String const&) const;
  [[nodiscard]] bool operator==(StringView) const;
  [[nodiscard]] bool operator==(char const*) const;

diff --git a/AK/StringBase.h b/AK/StringBase.h
@@ -6,6 +6,7 @@
 
 #pragma once
 
+#include <AK/Badge.h>
 #include <AK/Endian.h>
 #include <AK/Forward.h>
 
@@ -70,6 +71,8 @@ class StringBase {
 
  void did_create_fly_string(Badge<FlyString>) const;
 
+ [[nodiscard]] ALWAYS_INLINE FlatPtr raw(Badge<FlyString>) const { return bit_cast<FlatPtr>(m_data); }
+
 protected:
  template<typename Func>
  ErrorOr<void> replace_with_new_string(size_t byte_count, Func&& callback)