Skip to content

Commit

Permalink
LibWeb: Remove CalculatedStyleValue from Time
Browse files Browse the repository at this point in the history
Time also isn't used anywhere yet, hooray!
  • Loading branch information
AtkinsSJ authored and awesomekling committed Mar 30, 2023
1 parent bf915fd commit ac43507
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 33 deletions.
25 changes: 2 additions & 23 deletions Userland/Libraries/LibWeb/CSS/Time.cpp
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
/*
* Copyright (c) 2022, Sam Atkins <[email protected]>
* Copyright (c) 2022-2023, Sam Atkins <[email protected]>
*
* SPDX-License-Identifier: BSD-2-Clause
*/

#include "Time.h"
#include <LibWeb/CSS/StyleValue.h>
#include <LibWeb/CSS/Percentage.h>

namespace Web::CSS {

Expand All @@ -21,37 +21,24 @@ Time::Time(float value, Type type)
{
}

Time Time::make_calculated(NonnullRefPtr<CalculatedStyleValue> calculated_style_value)
{
Time frequency { 0, Type::Calculated };
frequency.m_calculated_style = move(calculated_style_value);
return frequency;
}

Time Time::make_seconds(float value)
{
return { value, Type::S };
}

Time Time::percentage_of(Percentage const& percentage) const
{
VERIFY(!is_calculated());

return Time { percentage.as_fraction() * m_value, m_type };
}

ErrorOr<String> Time::to_string() const
{
if (is_calculated())
return m_calculated_style->to_string();
return String::formatted("{}{}", m_value, unit_name());
}

float Time::to_seconds() const
{
switch (m_type) {
case Type::Calculated:
return m_calculated_style->resolve_time()->to_seconds();
case Type::S:
return m_value;
case Type::Ms:
Expand All @@ -63,8 +50,6 @@ float Time::to_seconds() const
StringView Time::unit_name() const
{
switch (m_type) {
case Type::Calculated:
return "calculated"sv;
case Type::S:
return "s"sv;
case Type::Ms:
Expand All @@ -83,10 +68,4 @@ Optional<Time::Type> Time::unit_from_name(StringView name)
return {};
}

NonnullRefPtr<CalculatedStyleValue> Time::calculated_style_value() const
{
VERIFY(!m_calculated_style.is_null());
return *m_calculated_style;
}

}
11 changes: 1 addition & 10 deletions Userland/Libraries/LibWeb/CSS/Time.h
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
/*
* Copyright (c) 2022, Sam Atkins <[email protected]>
* Copyright (c) 2022-2023, Sam Atkins <[email protected]>
*
* SPDX-License-Identifier: BSD-2-Clause
*/

#pragma once

#include <AK/RefPtr.h>
#include <AK/String.h>
#include <LibWeb/Forward.h>

Expand All @@ -15,7 +14,6 @@ namespace Web::CSS {
class Time {
public:
enum class Type {
Calculated,
S,
Ms,
};
Expand All @@ -24,20 +22,14 @@ class Time {

Time(int value, Type type);
Time(float value, Type type);
static Time make_calculated(NonnullRefPtr<CalculatedStyleValue>);
static Time make_seconds(float);
Time percentage_of(Percentage const&) const;

bool is_calculated() const { return m_type == Type::Calculated; }
NonnullRefPtr<CalculatedStyleValue> calculated_style_value() const;

ErrorOr<String> to_string() const;
float to_seconds() const;

bool operator==(Time const& other) const
{
if (is_calculated())
return m_calculated_style == other.m_calculated_style;
return m_type == other.m_type && m_value == other.m_value;
}

Expand All @@ -46,7 +38,6 @@ class Time {

Type m_type;
float m_value { 0 };
RefPtr<CalculatedStyleValue> m_calculated_style;
};

}
Expand Down

0 comments on commit ac43507

Please sign in to comment.