LibWeb: Make DOMImplementation.createHTMLDocument() create HTMLDocument

Prior to this change, this API would actually create an XML Document(!)
lanmonster · Mar 11, 2024 · 99ca2cc · 99ca2cc
1 parent b9bacb3
commit 99ca2cc
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 2 deletions.
diff --git a/Tests/LibWeb/Text/expected/DOM/DOMImplementation-createHTMLDocument.txt b/Tests/LibWeb/Text/expected/DOM/DOMImplementation-createHTMLDocument.txt
@@ -0,0 +1,4 @@
+ [object HTMLDocument]
+true
+[object HTMLDocument]
+true
diff --git a/Tests/LibWeb/Text/input/DOM/DOMImplementation-createHTMLDocument.html b/Tests/LibWeb/Text/input/DOM/DOMImplementation-createHTMLDocument.html
@@ -0,0 +1,12 @@
+<body>
+<script src="../include.js"></script>
+<script>
+ test(() => {
+ println(document);
+ println(document instanceof HTMLDocument);
+ let newDocument = document.implementation.createHTMLDocument();
+ println(newDocument);
+ println(newDocument instanceof HTMLDocument);
+ });
+</script>
+</body>
diff --git a/Userland/Libraries/LibWeb/DOM/DOMImplementation.cpp b/Userland/Libraries/LibWeb/DOM/DOMImplementation.cpp
@@ -12,6 +12,7 @@
 #include <LibWeb/DOM/ElementFactory.h>
 #include <LibWeb/DOM/Text.h>
 #include <LibWeb/DOM/XMLDocument.h>
+#include <LibWeb/HTML/HTMLDocument.h>
 #include <LibWeb/HTML/Origin.h>
 #include <LibWeb/Namespace.h>
 
@@ -91,10 +92,11 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<Document>> DOMImplementation::create_docume
 JS::NonnullGCPtr<Document> DOMImplementation::create_html_document(Optional<String> const& title) const
 {
  // 1. Let doc be a new document that is an HTML document.
- auto html_document = Document::create(realm());
+ auto html_document = HTML::HTMLDocument::create(realm());
 
  // 2. Set doc’s content type to "text/html".
  html_document->set_content_type("text/html"_string);
+ html_document->set_document_type(DOM::Document::Type::HTML);
 
  html_document->set_ready_for_post_load_tasks(true);
 

diff --git a/Userland/Libraries/LibWeb/HTML/HTMLDocument.cpp b/Userland/Libraries/LibWeb/HTML/HTMLDocument.cpp
@@ -27,4 +27,10 @@ JS::NonnullGCPtr<HTMLDocument> HTMLDocument::create(JS::Realm& realm, URL const&
  return realm.heap().allocate<HTMLDocument>(realm, realm, url);
 }
 
+void HTMLDocument::initialize(JS::Realm& realm)
+{
+ Base::initialize(realm);
+ set_prototype(&Bindings::ensure_web_prototype<Bindings::HTMLDocumentPrototype>(realm, "HTMLDocument"_fly_string));
+}
+
 }
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLDocument.h b/Userland/Libraries/LibWeb/HTML/HTMLDocument.h
@@ -15,7 +15,7 @@ namespace Web::HTML {
 // https://github.com/whatwg/html/issues/4792
 // https://github.com/whatwg/dom/issues/221
 class HTMLDocument final : public DOM::Document {
- JS_CELL(HTMLDocument, DOM::Document);
+ WEB_PLATFORM_OBJECT(HTMLDocument, DOM::Document);
  JS_DECLARE_ALLOCATOR(HTMLDocument);
 
 public:
@@ -25,6 +25,8 @@ class HTMLDocument final : public DOM::Document {
  WebIDL::ExceptionOr<JS::NonnullGCPtr<HTMLDocument>> construct_impl(JS::Realm&);
 
 private:
+ virtual void initialize(JS::Realm&) override;
+
  HTMLDocument(JS::Realm&, URL const&);
 };