LibJS/Bytecode: Add fast paths for equality checks with same-tag values

lanmonster · Mar 4, 2024 · 55e9df4 · 55e9df4
1 parent 795149e
commit 55e9df4
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/Userland/Libraries/LibJS/Bytecode/Interpreter.cpp b/Userland/Libraries/LibJS/Bytecode/Interpreter.cpp
@@ -119,23 +119,39 @@ NonnullOwnPtr<CallFrame> CallFrame::create(size_t register_count)
  return call_frame;
 }
 
-static ThrowCompletionOr<Value> loosely_inequals(VM& vm, Value src1, Value src2)
+ALWAYS_INLINE static ThrowCompletionOr<Value> loosely_inequals(VM& vm, Value src1, Value src2)
 {
+ if (src1.tag() == src2.tag()) {
+ if (src1.is_int32() || src1.is_object() || src1.is_boolean() || src1.is_nullish())
+ return Value(src1.encoded() != src2.encoded());
+ }
  return Value(!TRY(is_loosely_equal(vm, src1, src2)));
 }
 
-static ThrowCompletionOr<Value> loosely_equals(VM& vm, Value src1, Value src2)
+ALWAYS_INLINE static ThrowCompletionOr<Value> loosely_equals(VM& vm, Value src1, Value src2)
 {
+ if (src1.tag() == src2.tag()) {
+ if (src1.is_int32() || src1.is_object() || src1.is_boolean() || src1.is_nullish())
+ return Value(src1.encoded() == src2.encoded());
+ }
  return Value(TRY(is_loosely_equal(vm, src1, src2)));
 }
 
-static ThrowCompletionOr<Value> strict_inequals(VM&, Value src1, Value src2)
+ALWAYS_INLINE static ThrowCompletionOr<Value> strict_inequals(VM&, Value src1, Value src2)
 {
+ if (src1.tag() == src2.tag()) {
+ if (src1.is_int32() || src1.is_object() || src1.is_boolean() || src1.is_nullish())
+ return Value(src1.encoded() != src2.encoded());
+ }
  return Value(!is_strictly_equal(src1, src2));
 }
 
-static ThrowCompletionOr<Value> strict_equals(VM&, Value src1, Value src2)
+ALWAYS_INLINE static ThrowCompletionOr<Value> strict_equals(VM&, Value src1, Value src2)
 {
+ if (src1.tag() == src2.tag()) {
+ if (src1.is_int32() || src1.is_object() || src1.is_boolean() || src1.is_nullish())
+ return Value(src1.encoded() == src2.encoded());
+ }
  return Value(is_strictly_equal(src1, src2));
 }
 

diff --git a/Userland/Libraries/LibJS/Runtime/Value.h b/Userland/Libraries/LibJS/Runtime/Value.h
@@ -131,6 +131,8 @@ class Value {
  Number,
  };
 
+ [[nodiscard]] u16 tag() const { return m_value.tag; }
+
  bool is_empty() const { return m_value.tag == EMPTY_TAG; }
  bool is_undefined() const { return m_value.tag == UNDEFINED_TAG; }
  bool is_null() const { return m_value.tag == NULL_TAG; }