Skip to content

Commit

Permalink
Tests/AK: Re-enable HashTable<double> test
Browse files Browse the repository at this point in the history
The incorrect UBSan alignment check that made this test fail has been
fixed in Clang 15.

Closes SerenityOS#13614
  • Loading branch information
BertalanD authored and IdanHo committed Nov 15, 2022
1 parent 8d65df9 commit 269a931
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions Tests/AK/TestHashTable.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,6 @@ TEST_CASE(floats)
EXPECT(table.contains(2.0f));
}

// FIXME: Enable this test once it doesn't trigger UBSAN.
#if 0
TEST_CASE(doubles)
{
HashTable<double> table;
Expand All @@ -281,7 +279,6 @@ TEST_CASE(doubles)
EXPECT(table.contains(1.0));
EXPECT(table.contains(2.0));
}
#endif

// Inserting and removing a bunch of elements will "thrash" the table, leading to a lot of "deleted" markers.
BENCHMARK_CASE(benchmark_thrashing)
Expand Down

0 comments on commit 269a931

Please sign in to comment.