Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Dynamic tooltipTitle, id mapping bugfix for last ParameterCompon… #51

Merged
merged 3 commits into from
Mar 20, 2023

Conversation

ScripterSugar
Copy link
Contributor

Resolving #47

I'm not touching hard-coded type={'str'} line here because I'm not certain about its side-effects.
It must be addressed as separated issue IMO.

@ogabrielluiz
Copy link
Contributor

ogabrielluiz commented Mar 20, 2023

LGTM.

@lucaseduoli, you?

I'll merge this into dev and we look into it closely but from my tests it fixes the issue.

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue of not being able to connect OpenAI to tools

@ogabrielluiz
Copy link
Contributor

@ScripterSugar we'll merge into dev and prepare a release for today asap.

@ogabrielluiz ogabrielluiz changed the base branch from main to dev March 20, 2023 10:11
@ogabrielluiz ogabrielluiz merged commit 3032998 into langflow-ai:dev Mar 20, 2023
@ScripterSugar ScripterSugar deleted the typeValidationBugFix branch March 20, 2023 10:14
@lucaseduoli
Copy link
Collaborator

LGTM, thanks for the contribution! All my tests passed too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants