Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update tests to work on Github Actions CI #2366

Merged
merged 33 commits into from
Jun 27, 2024
Merged

Conversation

Cristhianzl
Copy link
Collaborator

Description

Updating tests to function correctly on GitHub Actions CI environment.

Changes Made

  • Updated test scripts and configurations to align with GitHub Actions CI requirements.
  • Ensured all tests pass successfully in the GitHub Actions CI workflow.

Reason for Changes

To ensure continuous integration (CI) pipelines run smoothly and tests are executed properly within GitHub Actions.

…st parallelism

✅ (basicExamples.spec.ts): add waitForSelector for 'fit view' to ensure element is loaded

✅ (basicExamples.spec.ts): add waitForSelector for 'built successfully' to ensure element is loaded

✅ (chatInputOutput.spec.ts): add waitForSelector for 'extended-disclosure' to ensure element is loaded

✅ (codeAreaModalComponent.spec.ts): add waitForSelector for 'extended-disclosure' to ensure element is loaded

✅ (dropdownComponent.spec.ts): add waitForSelector for 'extended-disclosure' to ensure element is loaded

✅ (fileUploadComponent.spec.ts): add waitForSelector for 'extended-disclosure' to ensure element is loaded

✅ (filterEdge.spec.ts): add waitForSelector for 'extended-disclosure' to ensure element is loaded

✅ (filterEdge.spec.ts): update test expectations for 'disclosure-agents' to be visible

✅ (floatComponent.spec.ts): add waitForSelector for 'extended-disclosure' to ensure element is loaded

✅ (flowPage.spec.ts): add waitForSelector for 'extended-disclosure' to ensure element is loaded

✅ (folders.spec.ts): add waitForSelector for 'icon-ChevronLeft' to ensure element is loaded

✅ (folders.spec.ts): update folder name input and visibility check to improve reliability

✅ (generalBugs.spec.ts): add waitForSelector for 'extended-disclosure' to ensure element is loaded

✅ (tests): replace waitForTimeout with waitForSelector in end-to-end tests

Replace `waitForTimeout` with `waitForSelector` to improve test reliability and reduce flakiness.
@Cristhianzl Cristhianzl self-assigned this Jun 26, 2024
…r CI

💡 (textAreaWrapper): add data-testid attribute for better test targeting
✅ (actionsMainPage.spec.ts): add waitForSelector for better test stability
✅ (basicExamples.spec.ts): replace waitForTimeout with waitForSelector
✅ (basicExamples.spec.ts): use data-testid for chat input for consistency
✅ (memoryChatbot.spec.ts): replace waitForTimeout with waitForSelector
✅ (memoryChatbot.spec.ts): use data-testid for chat input for consistency
✅ (documentQA.spec.ts): replace waitForTimeout with waitForSelector
✅ (documentQA.spec.ts): use data-testid for chat input for consistency
✅ (vectorStoreRAG.spec.ts): replace waitForTimeout with waitForSelector
✅ (vectorStoreRAG.spec.ts): use data-testid for chat input for consistency

✅ (tests): add waitForSelector to ensure elements are loaded before interaction

✅ (tests): add waitForSelector for 'fit view' button in end-to-end tests
✅ (store.spec.ts): update test selector to use new data-testid attribute
♻️ (textInputOutput.spec.ts): refactor element selection and interaction logic for clarity and maintainability
Add steps to select "gpt-4o" model in various end-to-end tests to ensure
consistency and accuracy in test execution.
✅ (tests): add waitForTimeout to ensure stability in end-to-end tests
…in CI

✅ (basicExamples.spec.ts): refactor API key check to run at the start of tests
✅ (index.tsx): add data-testid attribute to checkbox component
✅ (basicExamples.spec.ts): add waitForSelector for send icon to improve test stability
✅ (chatInputOutputUser.spec.ts): add waitForSelector for send icon to improve test stability
✅ (deleteComponentFlows.spec.ts): add waitForSelector for various elements to improve test stability
✅ (generalBugs.spec.ts): add waitForSelector for send icon to improve test stability
@Cristhianzl Cristhianzl marked this pull request as ready for review June 27, 2024 02:46
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. enhancement New feature or request javascript Pull requests that update Javascript code labels Jun 27, 2024
@Cristhianzl Cristhianzl marked this pull request as draft June 27, 2024 03:18
@Cristhianzl Cristhianzl marked this pull request as ready for review June 27, 2024 04:14
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jun 27, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 27, 2024
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Jun 27, 2024
Merged via the queue into dev with commit 839e547 Jun 27, 2024
16 of 17 checks passed
@ogabrielluiz ogabrielluiz deleted the cz/fixTestsCI branch June 27, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants