-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update tests to work on Github Actions CI #2366
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and improve readability
…st parallelism ✅ (basicExamples.spec.ts): add waitForSelector for 'fit view' to ensure element is loaded ✅ (basicExamples.spec.ts): add waitForSelector for 'built successfully' to ensure element is loaded ✅ (chatInputOutput.spec.ts): add waitForSelector for 'extended-disclosure' to ensure element is loaded ✅ (codeAreaModalComponent.spec.ts): add waitForSelector for 'extended-disclosure' to ensure element is loaded ✅ (dropdownComponent.spec.ts): add waitForSelector for 'extended-disclosure' to ensure element is loaded ✅ (fileUploadComponent.spec.ts): add waitForSelector for 'extended-disclosure' to ensure element is loaded ✅ (filterEdge.spec.ts): add waitForSelector for 'extended-disclosure' to ensure element is loaded ✅ (filterEdge.spec.ts): update test expectations for 'disclosure-agents' to be visible ✅ (floatComponent.spec.ts): add waitForSelector for 'extended-disclosure' to ensure element is loaded ✅ (flowPage.spec.ts): add waitForSelector for 'extended-disclosure' to ensure element is loaded ✅ (folders.spec.ts): add waitForSelector for 'icon-ChevronLeft' to ensure element is loaded ✅ (folders.spec.ts): update folder name input and visibility check to improve reliability ✅ (generalBugs.spec.ts): add waitForSelector for 'extended-disclosure' to ensure element is loaded ✅ (tests): replace waitForTimeout with waitForSelector in end-to-end tests Replace `waitForTimeout` with `waitForSelector` to improve test reliability and reduce flakiness.
…r CI 💡 (textAreaWrapper): add data-testid attribute for better test targeting ✅ (actionsMainPage.spec.ts): add waitForSelector for better test stability ✅ (basicExamples.spec.ts): replace waitForTimeout with waitForSelector ✅ (basicExamples.spec.ts): use data-testid for chat input for consistency ✅ (memoryChatbot.spec.ts): replace waitForTimeout with waitForSelector ✅ (memoryChatbot.spec.ts): use data-testid for chat input for consistency ✅ (documentQA.spec.ts): replace waitForTimeout with waitForSelector ✅ (documentQA.spec.ts): use data-testid for chat input for consistency ✅ (vectorStoreRAG.spec.ts): replace waitForTimeout with waitForSelector ✅ (vectorStoreRAG.spec.ts): use data-testid for chat input for consistency ✅ (tests): add waitForSelector to ensure elements are loaded before interaction ✅ (tests): add waitForSelector for 'fit view' button in end-to-end tests
✅ (store.spec.ts): update test selector to use new data-testid attribute ♻️ (textInputOutput.spec.ts): refactor element selection and interaction logic for clarity and maintainability
Add steps to select "gpt-4o" model in various end-to-end tests to ensure consistency and accuracy in test execution.
✅ (tests): add waitForTimeout to ensure stability in end-to-end tests
…or debugging flow data
…in CI ✅ (basicExamples.spec.ts): refactor API key check to run at the start of tests
✅ (index.tsx): add data-testid attribute to checkbox component ✅ (basicExamples.spec.ts): add waitForSelector for send icon to improve test stability ✅ (chatInputOutputUser.spec.ts): add waitForSelector for send icon to improve test stability ✅ (deleteComponentFlows.spec.ts): add waitForSelector for various elements to improve test stability ✅ (generalBugs.spec.ts): add waitForSelector for send icon to improve test stability
…use waitForSelector for consistency
…ds for better distribution of tests
… into cz/fixTestsCI
ogabrielluiz
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
javascript
Pull requests that update Javascript code
lgtm
This PR has been approved by a maintainer
size:XXL
This PR changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating tests to function correctly on GitHub Actions CI environment.
Changes Made
Reason for Changes
To ensure continuous integration (CI) pipelines run smoothly and tests are executed properly within GitHub Actions.