Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add types to functions, components and hooks that are missing it #2340

Closed
wants to merge 20 commits into from

Conversation

igorrCarvalho
Copy link
Collaborator

@igorrCarvalho igorrCarvalho commented Jun 25, 2024

This PR adds types to all functions and components that were previously missing them.

ogabrielluiz and others added 19 commits June 24, 2024 14:05
Add 1.0 banner
…leware (#2316)

* chore: update linting workflows to include dev branch in merge_group

* Update README.md

Add 1.0 banner

* Update README.md

* chore: update package versions in pyproject.toml files

* refactor: update "created_at" column type to use the "sa" module for consistency

* Update README.md

Add 1.0 banner

* chore: Remove unused import in ToolCallingAgent.py

* fix: adapt RequestCancelledMiddleware to handle cancelled requests

* chore: Remove unused import in test_helper_components.py

* refactor: Declare queue variable with explicit type in RequestCancelledMiddleware

---------

Co-authored-by: Rodrigo Nader <[email protected]>
The commit updates the versions of the `pydantic-settings` and `tenacity` packages in the `poetry.lock` file. The `pydantic-settings` version is updated from 2.3.3 to 2.3.4, and the `tenacity` version is updated from 8.4.1 to 8.4.2.
Add 1.0 banner
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 25, 2024
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 2:13pm

@dosubot dosubot bot added the javascript Pull requests that update Javascript code label Jun 25, 2024
github-actions[bot]

This comment was marked as resolved.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a more meaningful PR description with at least 25 characters.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a more meaningful PR description with at least 25 characters.

@zzzming zzzming self-requested a review June 25, 2024 14:35
Copy link
Collaborator

@zzzming zzzming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR merging to main or dev?

@igorrCarvalho igorrCarvalho changed the base branch from main to dev June 25, 2024 14:57
@igorrCarvalho
Copy link
Collaborator Author

Is this PR merging to main or dev?

Merging on dev. Ive fixed it. Thanks!

Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 27, 2024
@anovazzi1 anovazzi1 self-requested a review June 27, 2024 19:55
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too much outdated, need some cherry pick in the types commit

@anovazzi1 anovazzi1 closed this Jun 27, 2024
@anovazzi1
Copy link
Contributor

this branch is broken and is too far from the current dev branch

github-merge-queue bot pushed a commit that referenced this pull request Jun 28, 2024
#2411)

cherry pick from #2340 which adds more types to frontend code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants