Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve makefile #2338

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Improve makefile #2338

merged 5 commits into from
Jun 25, 2024

Conversation

carlosrcoelho
Copy link
Contributor

This PR is an adjustment to kill the backend process on Makefile.

Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 8:49pm

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 25, 2024
@dosubot dosubot bot added bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jun 25, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 25, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a more meaningful PR title with at least 15 characters.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jun 25, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 25, 2024
@italojohnny italojohnny changed the title Fix makefile Improve makefile Jun 25, 2024
@ogabrielluiz ogabrielluiz changed the base branch from main to dev June 25, 2024 21:34
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 25, 2024
Copy link

vercel bot commented Jun 25, 2024

Deployment failed with the following error:

Resource is limited - try again in 5 minutes (more than 100, code: "api-deployments-free-per-day").

@ogabrielluiz ogabrielluiz merged commit 146ef8c into dev Jun 25, 2024
8 of 12 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-makefile branch June 25, 2024 22:52
ogabrielluiz added a commit that referenced this pull request Jun 27, 2024
* Update Makefile to use command substitution for killing process

* break long lines into shorter ones

* replace fixed values with variables

* correct the unit test coverage report

---------

Co-authored-by: italojohnny <[email protected]>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
ogabrielluiz added a commit that referenced this pull request Jun 27, 2024
* Update Makefile to use command substitution for killing process

* break long lines into shorter ones

* replace fixed values with variables

* correct the unit test coverage report

---------

Co-authored-by: italojohnny <[email protected]>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
ogabrielluiz added a commit that referenced this pull request Jul 1, 2024
* Update Makefile to use command substitution for killing process

* break long lines into shorter ones

* replace fixed values with variables

* correct the unit test coverage report

---------

Co-authored-by: italojohnny <[email protected]>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants