Updating Tests and Fixing Related Bugs #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ (textAreaComponent): add Case component for conditional rendering ♻️ (editNodeModal): remove commented-out useEffect code ✅ (basicExamples.spec): update test selectors and increase timeout values ✅ (filterEdge.spec.ts): update test IDs to match new naming conventions ✅ (inputListComponent.spec.ts, intComponent.spec.ts): update test IDs and streamline test steps for consistency and clarity ✅ (keyPairListComponent.spec.ts): update test ID for model element ✅ (keyPairListComponent.spec.ts): add steps to test editing model options and saving changes
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
size:L
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dosubot
bot
added
bug
…mponents - Update test selectors for better accuracy - Add keyboard interaction in chatInputOutputUser.spec.ts - Improve file handling in chat image upload test - Refine prompt modal component tests for better validation - Enhance twoEdges.spec.ts with additional view controls
…for better debugging
…into cz/tests-fix
…into cz/tests-fix
…o improve stability ✅ (textInputOutput.spec.ts): add waitFor visibility checks to ensure elements are visible before interaction
dosubot
bot
added
size:XL
✅ (tests): add waitForSelector to ensure elements are loaded before interaction
…peed up tests ✅ (chatInputOutputUser.spec.ts): increase timeout for AI response to 100000ms ✅ (chatInputOutputUser.spec.ts): correct file path for image upload test ✅ (deleteComponentFlows.spec.ts): change waitFor to target last checkbox-component ✅ (store.spec.ts): increase timeout for share button to 100000ms
ogabrielluiz
added a commit
that referenced
this pull request
Jun 25, 2024
* 🐛 (tableNodeCellRender): fix templateValue check to use Object.keys ✨ (textAreaComponent): add Case component for conditional rendering ♻️ (editNodeModal): remove commented-out useEffect code ✅ (basicExamples.spec): update test selectors and increase timeout values ✅ (filterEdge.spec.ts): update test IDs to match new naming conventions ✅ (inputListComponent.spec.ts, intComponent.spec.ts): update test IDs and streamline test steps for consistency and clarity ✅ (keyPairListComponent.spec.ts): update test ID for model element ✅ (keyPairListComponent.spec.ts): add steps to test editing model options and saving changes * ✅ (tests): update end-to-end tests for chat input/output and modal components - Update test selectors for better accuracy - Add keyboard interaction in chatInputOutputUser.spec.ts - Improve file handling in chat image upload test - Refine prompt modal component tests for better validation - Enhance twoEdges.spec.ts with additional view controls * ♻️ (tests): refactor repeated click actions into reusable function in e2e tests * ✅ (tests): replace waitForTimeout with waitForSelector in end-to-end tests * ✅ (typescript_test.yml): add --debug flag to Playwright test command for better debugging * ✅ (typescript_test.yml): enable trace option in Playwright tests for better debugging * ✅ (typescript_test.yml): reduce Playwright test workers from 2 to 1 to improve stability ✅ (textInputOutput.spec.ts): add waitFor visibility checks to ensure elements are visible before interaction * ✅ (tests): update paths for test assets to correct locations ✅ (tests): add waitForSelector to ensure elements are loaded before interaction * ✅ (typescript_test.yml): increase Playwright workers from 1 to 2 to speed up tests ✅ (chatInputOutputUser.spec.ts): increase timeout for AI response to 100000ms ✅ (chatInputOutputUser.spec.ts): correct file path for image upload test ✅ (deleteComponentFlows.spec.ts): change waitFor to target last checkbox-component ✅ (store.spec.ts): increase timeout for share button to 100000ms * 🐛 (flows.py): ensure flow names are unique by appending a number if necessary * Apply Ruff formatting --------- Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]> Co-authored-by: Cristhianzl <[email protected]>
ogabrielluiz
added a commit
that referenced
this pull request
Jun 25, 2024
* 🐛 (tableNodeCellRender): fix templateValue check to use Object.keys ✨ (textAreaComponent): add Case component for conditional rendering ♻️ (editNodeModal): remove commented-out useEffect code ✅ (basicExamples.spec): update test selectors and increase timeout values ✅ (filterEdge.spec.ts): update test IDs to match new naming conventions ✅ (inputListComponent.spec.ts, intComponent.spec.ts): update test IDs and streamline test steps for consistency and clarity ✅ (keyPairListComponent.spec.ts): update test ID for model element ✅ (keyPairListComponent.spec.ts): add steps to test editing model options and saving changes * ✅ (tests): update end-to-end tests for chat input/output and modal components - Update test selectors for better accuracy - Add keyboard interaction in chatInputOutputUser.spec.ts - Improve file handling in chat image upload test - Refine prompt modal component tests for better validation - Enhance twoEdges.spec.ts with additional view controls * ♻️ (tests): refactor repeated click actions into reusable function in e2e tests * ✅ (tests): replace waitForTimeout with waitForSelector in end-to-end tests * ✅ (typescript_test.yml): add --debug flag to Playwright test command for better debugging * ✅ (typescript_test.yml): enable trace option in Playwright tests for better debugging * ✅ (typescript_test.yml): reduce Playwright test workers from 2 to 1 to improve stability ✅ (textInputOutput.spec.ts): add waitFor visibility checks to ensure elements are visible before interaction * ✅ (tests): update paths for test assets to correct locations ✅ (tests): add waitForSelector to ensure elements are loaded before interaction * ✅ (typescript_test.yml): increase Playwright workers from 1 to 2 to speed up tests ✅ (chatInputOutputUser.spec.ts): increase timeout for AI response to 100000ms ✅ (chatInputOutputUser.spec.ts): correct file path for image upload test ✅ (deleteComponentFlows.spec.ts): change waitFor to target last checkbox-component ✅ (store.spec.ts): increase timeout for share button to 100000ms * 🐛 (flows.py): ensure flow names are unique by appending a number if necessary * Apply Ruff formatting --------- Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]> Co-authored-by: Cristhianzl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to our test suite and fixes several bugs identified during testing. The key changes and improvements are as follows:
🐛 (tableNodeCellRender): fix templateValue check to use Object.keys
✨ (textAreaComponent): add Case component for conditional rendering
♻️ (editNodeModal): remove commented-out useEffect code
✅ (basicExamples.spec): update test selectors and increase timeout values
✅ (filterEdge.spec.ts): update test IDs to match new naming conventions
✅ (inputListComponent.spec.ts, intComponent.spec.ts): update test IDs and streamline test steps for consistency and clarity
✅ (keyPairListComponent.spec.ts): update test ID for model element
✅ (keyPairListComponent.spec.ts): add steps to test editing model options and saving changes