-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixes part of text input output component test where component popover elements are block others #2297
Fix: Fixes part of text input output component test where component popover elements are block others #2297
Conversation
…r elements are block others
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hi @596050, LGTM. |
Deployment failed with the following error:
|
Hi @Cristhianzl , sure, we could offset the elements too? Should I create another PR to suggest that or add to this? I'm thinking: export const offsetElements = async ({
sourceElement,
targetElement,
page,
}) => {
// Get bounding boxes
const box1 = await sourceElement.boundingBox();
const box2 = await targetElement.boundingBox();
await page.mouse.move((box2?.x || 0) + 5, (box2?.y || 0) + 5);
await page.mouse.down();
// Move to the right of the source element
await page.mouse.move(
(box2?.x || 0) + (box2?.width || 0) / 2 + (box1?.width || 0),
box2?.y || 0,
);
await page.mouse.up();
}; which becomes: const component1 = await page.locator(
'//*[@id="react-flow-id"]/div/div[1]/div/div/div[2]/div[1]',
);
const element1 = await page.locator(
'//*[@id="react-flow-id"]/div/div[1]/div/div/div[2]/div[1]/div/div[2]/div[5]/button/div[1]',
);
const component2 = await page.locator(
'//*[@id="react-flow-id"]/div/div[1]/div/div/div[2]/div[2]',
);
const element2 = await page.locator(
'//*[@id="react-flow-id"]/div/div[1]/div/div/div[2]/div[2]/div/div[2]/div[3]/div/button/div[1]',
);
await offsetElements({
sourceElement: component1,
targetElement: component2,
page,
});
// ensure elements popups are not blocking
component1.blur();
component2.blur();
// Click and hold on the first element and move to the second element
await element1?.dragTo(element2);
// ensure the mouse button is up
await page.mouse.up(); Which should do something like this, the problem seems to have been components blocking eachother?: This seems to leave the env error in the tests: [WebServer] /home/runner/.cache/pypoetry/virtualenvs/langflow-9OwJkPRQ-py3.12/lib/python3.12/site-packages/langchain/agents/json_chat/base.py:22: SyntaxWarning: invalid escape sequence '\ '
"""Create an agent that uses JSON to format its logic, build for Chat Models.
Running 10 tests using 2 workers, shard 4 of 4
[WebServer] /home/runner/.cache/pypoetry/virtualenvs/langflow-9OwJkPRQ-py3.12/lib/python3.12/site-packages/anyio/streams/memory.py:[17](https://github.com/langflow-ai/langflow/actions/runs/9647385563/job/26606022066?pr=2297#step:13:18)7: ResourceWarning: Unclosed <MemoryObjectReceiveStream>
warnings.warn(
ResourceWarning: Enable tracemalloc to get the object allocation traceback
·×··×·F·····Removing the temp database
tempDbPath /home/runner/work/langflow/langflow/src/frontend/temp
Successfully removed the temp database
1) [chromium] › end-to-end/textInputOutput.spec.ts:6:5 › TextInputOutputComponent ────────────────
Error: expect(received).toBe(expected) // Object.is equality
Expected: true
Received: false
128 | if (!process.env.OPENAI_API_KEY) {
129 | //You must set the OPENAI_API_KEY on .env file to run this test
> 130 | expect(false).toBe(true);
| ^
131 | }
132 |
133 | await page
at /home/runner/work/langflow/langflow/src/frontend/tests/end-to-end/textInputOutput.spec.ts:130:[19](https://github.com/langflow-ai/langflow/actions/runs/9647385563/job/26606022066?pr=2297#step:13:20) |
Deployment failed with the following error:
|
fdcf24f
to
349913e
Compare
Deployment failed with the following error:
|
@596050 |
…leware (langflow-ai#2316) * chore: update linting workflows to include dev branch in merge_group * Update README.md Add 1.0 banner * Update README.md * chore: update package versions in pyproject.toml files * refactor: update "created_at" column type to use the "sa" module for consistency * Update README.md Add 1.0 banner * chore: Remove unused import in ToolCallingAgent.py * fix: adapt RequestCancelledMiddleware to handle cancelled requests * chore: Remove unused import in test_helper_components.py * refactor: Declare queue variable with explicit type in RequestCancelledMiddleware --------- Co-authored-by: Rodrigo Nader <[email protected]>
The commit updates the versions of the `pydantic-settings` and `tenacity` packages in the `poetry.lock` file. The `pydantic-settings` version is updated from 2.3.3 to 2.3.4, and the `tenacity` version is updated from 8.4.1 to 8.4.2.
Add 1.0 banner
299eaa5
to
4365e3d
Compare
Description:
This pull request refactors the selection and interaction of elements in the textInputOutput.spec.ts test file to improve code readability and ensure proper functionality.
Changes: