Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes react key error in browser on flow page for extra sidebar disclosure components #2295

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

596050
Copy link
Contributor

@596050 596050 commented Jun 24, 2024

This pull request addresses the React key error that appears in the browser console on the flow page, specifically for the extra sidebar disclosure components.

Screenshot 2024-06-24 at 07 51 25

Changes:

  • Added unique key props to Fragment component in the ExtraSidebar component to resolve the warning.
  • Remove Fragment component without key attribute wrapping DisclosureComponent

Before:

  • React warning in the console: "Each child in a list should have a unique 'key' prop."

After:

  • No React key warnings in the browser console.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 24, 2024
Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 3:38pm

@dosubot dosubot bot added the bug Something isn't working label Jun 24, 2024
@596050 596050 changed the title Fixes React key error in browser on flow page for extra sidebar disclosure components Fix: Fixes React key error in browser on flow page for extra sidebar disclosure components Jun 24, 2024
@lucaseduoli lucaseduoli changed the base branch from dev to main July 2, 2024 13:54
@lucaseduoli lucaseduoli changed the title Fix: Fixes React key error in browser on flow page for extra sidebar disclosure components fix: fixes react key error in browser on flow page for extra sidebar disclosure components Jul 2, 2024
@lucaseduoli lucaseduoli self-requested a review July 2, 2024 13:56
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 2, 2024
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anovazzi1 anovazzi1 enabled auto-merge (squash) July 2, 2024 21:26
@anovazzi1 anovazzi1 force-pushed the fix/frontend_flow_key_error branch from 84598e7 to c6c1e13 Compare July 2, 2024 21:26
@anovazzi1 anovazzi1 merged commit be21f2f into langflow-ai:main Jul 4, 2024
19 checks passed
ogabrielluiz pushed a commit to yaitec/langflow that referenced this pull request Jul 9, 2024
…disclosure components (langflow-ai#2295)

Fixes key error in browser on flow page for extra sidebar disclosure components

Co-authored-by: Lucas Oliveira <[email protected]>
Co-authored-by: anovazzi1 <[email protected]>
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 10, 2024
…disclosure components (langflow-ai#2295)

Fixes key error in browser on flow page for extra sidebar disclosure components

Co-authored-by: Lucas Oliveira <[email protected]>
Co-authored-by: anovazzi1 <[email protected]>
(cherry picked from commit be21f2f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants