Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Flows losing reference of folder when renaming current folder #2269

Merged
merged 6 commits into from
Jun 23, 2024

Conversation

Cristhianzl
Copy link
Collaborator

🐛 (folders.py): fix folder name update logic to ensure name changes are saved correctly

Copy link

vercel bot commented Jun 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 8:51pm

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 23, 2024
Copy link

render bot commented Jun 23, 2024

@dosubot dosubot bot added the bug Something isn't working label Jun 23, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo!

Fix these and this should be good.

src/backend/base/langflow/api/v1/folders.py Show resolved Hide resolved
src/backend/base/langflow/api/v1/folders.py Outdated Show resolved Hide resolved
…folder

♻️ (folders.py): refactor read_folders to return sorted folders using custom_sort
🐛 (folders.py): fix update_folder to refresh session after updating folder name
🐛 (folders.py): correct update statement to exclude flows not in the provided list
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 23, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 23, 2024
…lambda for sorting folders

🐛 (folders.py): fix update statement to correctly update flows with excluded folder IDs
♻️ (folders.py): refactor folder update logic to use session.add for better clarity and consistency
@Cristhianzl Cristhianzl merged commit 00ec361 into dev Jun 23, 2024
7 of 13 checks passed
@Cristhianzl Cristhianzl deleted the cz/fix-folder-losing-flows branch June 23, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants