Add i18n to the frontend #2260
Open
Add i18n to the frontend #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:XL
|
This is so awesome @skipandsnow I can't thank you enough. Should we go through defining a way to set it up on the settings page ? @anovazzi1 what do you think? |
|
I think this is a good idea, maybe a language dropdown in the settings page? |
I would like to help with it :) |
|
Hey @skipandsnow We are going to prioritize the #2149 since it was created first. Do you mind merging this one into it? Or we can merge it first, then we merge yours. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged 2 pull request #2149 #2242, complete the missing translation part and add traditional chinese.