Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store variables as Kubernetes Secrets #2231

Merged
merged 7 commits into from
Jun 22, 2024
Merged

Store variables as Kubernetes Secrets #2231

merged 7 commits into from
Jun 22, 2024

Conversation

zzzming
Copy link
Collaborator

@zzzming zzzming commented Jun 20, 2024

This PR introduces an alternate backend to store variable in kubernetes secrets.
It addresses these two feature requests
#2151
#2150

@ogabrielluiz
This implementation stores both Credential and Generic variables in Kubernetes secrets when setting_service.variable_store = "kubernetes"

Or the second option is to only store the variable type is Credential to Kubernetes secrets while the rest Generic still are stored in db. For that we can introduce a flag setting_service.credential_store

Let me know which one is more appropriate.

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 3:54am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. python Pull requests that update Python code labels Jun 20, 2024
@zzzming zzzming changed the title Store variables as Store variables as Kubernetes Secrets Jun 20, 2024
@zzzming zzzming marked this pull request as draft June 20, 2024 00:52
@zzzming zzzming marked this pull request as ready for review June 21, 2024 05:04
@dosubot dosubot bot added the enhancement New feature or request label Jun 21, 2024
@ogabrielluiz
Copy link
Contributor

This PR introduces an alternate backend to store variable in kubernetes secrets. It addresses these two feature requests #2151 #2150

@ogabrielluiz This implementation stores both Credential and Generic variables in Kubernetes secrets when setting_service.variable_store = "kubernetes"

Or the second option is to only store the variable type is Credential to Kubernetes secrets while the rest Generic still are stored in db. For that we can introduce a flag setting_service.credential_store

Let me know which one is more appropriate.

I think have different stores is ideal but I think it would add complexity.

Let's keep it as variable_store for now.

Thanks for this PR, ming. Looks really useful.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 21, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jun 21, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 22, 2024
@ogabrielluiz ogabrielluiz merged commit 20f7c67 into dev Jun 22, 2024
11 of 14 checks passed
@ogabrielluiz ogabrielluiz deleted the feature/secrets branch June 22, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants