Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: graph process should raise the actual error when failing #2225

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

nicoloboschi
Copy link
Collaborator

Currently when a vertex fails to be processed for an internal problem, the real error is only logged and not raised. Then the exception is ValueError: The message must be an iterator or an async iterator.
which is misleading and hard to understand

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 19, 2024
Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 0:43am

@dosubot dosubot bot added the bug Something isn't working label Jun 19, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 19, 2024
@ogabrielluiz ogabrielluiz merged commit 51c1aa1 into langflow-ai:dev Jun 19, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants