Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chat input must return text by default and output should accept Record, Message and str types #2208

Closed

Conversation

nicoloboschi
Copy link
Collaborator

@nicoloboschi nicoloboschi commented Jun 18, 2024

chat input:

  • it should use return_message default to False to keep backwards compatibility

chat output:

  • it should accepts all the combinations as expected: record, message and string

To reproduce the issue you can simply connect a chat input with a chat output.

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 2:08pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jun 18, 2024
@nicoloboschi
Copy link
Collaborator Author

I'm finding more issues, I'll make this PR as draft

@nicoloboschi nicoloboschi marked this pull request as draft June 18, 2024 11:19
@nicoloboschi nicoloboschi changed the title chat output should accept Record type chat output should accept Record, Message and str types Jun 18, 2024
@nicoloboschi nicoloboschi changed the title chat output should accept Record, Message and str types fix: chat output should accept Record, Message and str types Jun 18, 2024
Copy link

vercel bot commented Jun 18, 2024

Deployment failed with the following error:

Resource is limited - try again in 8 seconds (more than 100, code: "api-deployments-free-per-day").

@nicoloboschi nicoloboschi changed the title fix: chat output should accept Record, Message and str types fix: chat input must return text by default and output should accept Record, Message and str types Jun 18, 2024
@nicoloboschi nicoloboschi marked this pull request as ready for review June 18, 2024 11:45
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 18, 2024
Copy link

vercel bot commented Jun 18, 2024

Deployment failed with the following error:

Resource is limited - try again in 9 minutes (more than 100, code: "api-deployments-free-per-day").

Copy link

vercel bot commented Jun 18, 2024

Deployment failed with the following error:

Resource is limited - try again in 5 minutes (more than 100, code: "api-deployments-free-per-day").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant