fix: add null type to allowable target onchange #2190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:S
ogabrielluiz
approved these changes
Jun 16, 2024
|
I agree too. |
|
Sounds good. I'll update the rest of the types and ping when it's ready for another look. Thanks |
jordanrfrazier
force-pushed
the
fix-onchange-to-null-values
branch
from
429cd14
to
c504923
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface: I don't know javascript.
For typed fields from the UI, when you entered a value then removed it, it would act as an empty string rather than reset to
null. For many fields, this is an invalid type, causing errors on build.This PR adds the
nulltype to the allowedonchangeevents, which is interpreted as the correctNonein python backend. Note this does mean that an empty string is no longer accepted as a valid input, but that seems okay. If this is the correct fix, I'll replicate on the other typed fields.