Correctly Handle Text File Encoding to Avoid 'GBK' Codec Errors #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The original read_text_file method encountered an error when importing a text file containing Chinese characters, specifically:
Error building vertex File: Error loading file /tmp/test.txt: 'gbk' codec can't decode byte 0xaf in position 7: illegal multibyte sequenceThis error occurred due to incorrect or incompatible character encoding when reading the file.
Solution:
To resolve this issue, the method was updated to automatically detect the file's encoding using the chardet library. The new implementation reads the file in binary mode to determine the encoding and then reopens the file with the detected encoding to properly read its content.
Testing:
The updated method was tested with various text files containing Chinese characters and other encodings to ensure compatibility and proper functionality.
Files previously causing decoding errors were successfully read without issues after the update.
This PR resolves the encoding problem by implementing automatic encoding detection, improving the robustness and reliability of the read_text_file method when handling files with different character sets.