Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Astra Assistants Support #2041

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Astra Assistants Support #2041

wants to merge 3 commits into from
+260 −4

Conversation

phact
Copy link
Contributor

@phact phact commented Jun 1, 2024

Added a few components to support astra-assistants, an open source implementation of OpenAI's assistants API that supports different LLM and embedding providers.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 1, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 5:42pm

@dosubot dosubot bot added enhancement New feature or request python Pull requests that update Python code labels Jun 1, 2024
@ogabrielluiz
Copy link
Contributor

Hey @phact !!

How are you?

This looks so cool!

@phact
Copy link
Contributor Author

phact commented Jun 3, 2024 •
edited
Loading

Hey @ogabrielluiz , doing great :)

Excited about this first stab at Assistants support. This is my first component contribution. What steps do you recommend to get it ready to merge? I plan to continue improving and maintaining Assistants support in langflow going forward if that works for you and the team.

ogabrielluiz
ogabrielluiz requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @phact

You might want to add build_config to the components so the Fields have better names and information on how to use them.

@phact phact requested a review from ogabrielluiz June 10, 2024 17:42
@phact
Copy link
Contributor Author

phact commented Jun 17, 2024

Hi @ogabrielluiz any additional feedback now that your suggestions were addressed?

Thanks!!!

@phact
Copy link
Contributor Author

phact commented Jun 25, 2024

Hey @ogabrielluiz just checking in. Congrats on the v1 launch!

@phact
Copy link
Contributor Author

phact commented Jul 10, 2024

@ogabrielluiz checking in on this

@ogabrielluiz
Copy link
Contributor

Thank you, Seb! We'll take a stance on this PR this week. I'll change the base to main and pick a category for them.

@ogabrielluiz ogabrielluiz changed the base branch from dev to main July 10, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz Awaiting requested review from ogabrielluiz

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request python Pull requests that update Python code size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phact @ogabrielluiz