Allow users to use dark mode #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is nice to allow users to choose light or dark mode based on their own needs, such as sensitivity to bright light.
|
Hey @brylie Could you check that all the pages in the docs work well in Dark mode, please? This is probably the reason we have that deactivated. |
|
The dark mode works overall, but isn't 100% covered. For example there are some page elements that have light backgrounds (pictured below.) However, having most things in dark mode is a significant improvement to reducing eye strain even when a few items still remain with light background. So, I'd urge the team to not let perfect be the enemy of good on this PR and consider it as an incremental step towards proper dark mode support. Code blocks and inline code use GitHub Light theme
|
|
Leaving the dark/light toggle enabled and switching to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1115
It is nice to allow users to choose light or dark mode based on their own needs, such as sensitivity to bright light.