Allow Solr commands to be defined via .lando.yml #48
Conversation
Update docker dependency from 20.10. to 23.0.
👷 Deploy request for lando-lagoon pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
We should also include a solr service (maybe not the drupal one - but a simple solr-8 with the correct CMD in the .lando.yml - and a test to check the mycore is there?
https://github.com/uselagoon/lagoon-images/blob/main/images/solr/8.Dockerfile#L78
|
This looks good to me - @pirog or @reynoldsalec - ok for you? |
| @@ -32,10 +32,6 @@ jobs: | |||
| run: yarn install --prefer-offline --frozen-lockfile | |||
|
|
|||
| # This block should eventually become use lando/actions-hyperdrive@v2 | |||
| - name: Verify Docker dependencies | |||
There was a problem hiding this comment.
Would be curious why this needs to get removed.
There was a problem hiding this comment.
Github upgrades the version of Docker in their runners more frequently these days, but not all runners update at the same time. At the time of testing some were 23 and some 24 so failing tests.
| * [Varnish](https://docs.lagoon.sh/lagoon/docker-images/varnish) | ||
|
|
||
| Note that we are testing against the "Drupal" variants of the above but it's _possible_ the base services work as well. | ||
|
|
||
| *Please note: if using [uselagoon/solr-8-drupal](https://github.com/uselagoon/lagoon-images/blob/main/images/solr-drupal/8.Dockerfile) you will need to add the following command to your `Solr` service in your `.lando.yml` file. Alternate Solr images are supported and may require different commands, this is just one example. |
There was a problem hiding this comment.
Do you guys have documentation on what precreate commands are necessary for different lagoon solr images?
There was a problem hiding this comment.
Mostly just this one, but if customers create their own cores, etc it can differ further.
Allows Solr commands to be defined via .lando.yml & updates docker depenencies.