Add support for containers #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 4, 2024
Closed
gnoack
reviewed
Apr 5, 2024
|
I'm holding this PR for now because tests don't pass with the latest kernel. It's related to landlock-lsm/linux@0710a1a (and landlock-lsm/linux@41cca05), because of private mount points. |
Don't use `git checkout` to not need to create index.lock, because the repository (but not the worktree) is read-only. Signed-off-by: Mickaël Salaün <[email protected]>
Signed-off-by: Mickaël Salaün <[email protected]>
srcres258
pushed a commit
to srcres258/linux-doc
that referenced
this pull request
May 7, 2024
According to the test environment, the mount point of the test's working
directory may be shared or not, which changes the visibility of the
nested "tmp" mount point for the test's parent process calling
umount("tmp").
This was spotted while running tests in containers [1], where mount
points are private.
Cc: Günther Noack <[email protected]>
Cc: Shuah Khan <[email protected]>
Link: landlock-lsm/landlock-test-tools#4 [1]
Fixes: 41cca05 ("selftests/harness: Fix TEST_F()'s vfork handling")
Reviewed-by: Kees Cook <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mickaël Salaün <[email protected]>
kuba-moo
pushed a commit
to linux-netdev/testing
that referenced
this pull request
May 12, 2024
According to the test environment, the mount point of the test's working
directory may be shared or not, which changes the visibility of the
nested "tmp" mount point for the test's parent process calling
umount("tmp").
This was spotted while running tests in containers [1], where mount
points are private.
Cc: Günther Noack <[email protected]>
Cc: Shuah Khan <[email protected]>
Link: landlock-lsm/landlock-test-tools#4 [1]
Fixes: 41cca05 ("selftests/harness: Fix TEST_F()'s vfork handling")
Reviewed-by: Kees Cook <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mickaël Salaün <[email protected]>
Fixed in Linux 6.9 with landlock-lsm/linux@af300a3 |
Old setpriv doesn't support +all capabilities, so generate and use the explicit list of supported capabilites instead. Signed-off-by: Mickaël Salaün <[email protected]>
Signed-off-by: Mickaël Salaün <[email protected]>
Signed-off-by: Mickaël Salaün <[email protected]>
Signed-off-by: Mickaël Salaün <[email protected]>
Signed-off-by: Mickaël Salaün <[email protected]>
We now support clang-format between version 14 and 17 included. Signed-off-by: Mickaël Salaün <[email protected]>
This is simpler and it enables concurrent use of the same image. Signed-off-by: Mickaël Salaün <[email protected]>
Signed-off-by: Mickaël Salaün <[email protected]>
Signed-off-by: Mickaël Salaün <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make easier to use specific tools (e.g. linters) and test against different distros.