Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove virtual package dependency of laminas/laminas-cache-storage-implementation #289

Merged

Conversation

boesing
Copy link
Member

@boesing boesing commented Jan 19, 2024

Q A
QA yes

Description

laminas/laminas-cache can be required by libraries, etc. without having to care about specific implementations. To avoid those libraries to have to require at least one specific implementation during development, the virtual package dependency is being removed. Virtual package dependencies should be moved into projects rather than libraries.

Closes #278

@boesing boesing added this to the 4.0.0 milestone Jan 19, 2024
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

…ge-implementation`

`laminas/laminas-cache` can be required by libraries, etc. without having to care about specific implementations. To avoid those libraries to have to require at least one specific implementation during development, the virtual package dependency is being removed. Virtual package dependencies should be moved into projects rather than libraries.

Signed-off-by: Maximilian Bösing <[email protected]>
@boesing boesing force-pushed the qa/remove-virtual-package-requirement branch from 09f09b3 to f19caca Compare January 21, 2024 13:45
@boesing boesing merged commit ce069bc into laminas:4.0.x Jan 21, 2024
21 checks passed
@boesing boesing deleted the qa/remove-virtual-package-requirement branch January 21, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove virtual package requirement laminas/laminas-cache-storage-implementation
2 participants