Introduce MetadataCapableInterface
#273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes benchmarks which are so available in each adapter repository and thus were redundant. Even tho, we are now unable to directly see impact on performance when changing `AbstractAdapter`, the adapters themselves keep track on performance due to renovate updating locks permanently. Longterm, the `AbstractAdapter` will most likely be removed in favor of cache backend specific features explicitly implemented. The `StorageInterface` will extend the PSR interfaces and requires the adapters to serve these interfaces in their own way. Therefore, removing benchmarks might be a good thing since the `StorageInterface` is meant to be feature complete. With laminas#130, some methods might be removed from the `StorageInterface` but extending that interface is not planned. Signed-off-by: Maximilian Bösing <[email protected]>
This provides a way for storage adapters to provide properly typed metadata objects. Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
boesing
force-pushed
the
feature/metadata-interface
branch
from
550b4cd
to
d04ba8a
Compare
boesing
commented
Aug 26, 2023
There was a problem hiding this comment.
mostly copy & paste from AbstractAdapterTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New Features
metadatanow implementsMetadataCapableInterfaceand provides a dedicated object containing all the metadata values it supports.Breaking Changes
AbstractAdapterandStorageInterfaceare not aware of the methodsgetMetadataanymore. These were moved to the newMetadataCapableInterfaceCapabilitiesdo not providesupportedMetadataanymore. The supported metadata is tied to the used storage adapter and thus, was already requiring projects to explicitly know the exact implementation of the cache backend in case of using these metadatas anywayKeyListIteratorand the correspondingIteratorInterfacedoes not provide themodeCURRENT_AS_METADATAanymoreFixes #130